[ui] Clear Images: Request a graph update after resetting the viewpoints and intrinsics #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug introduced by #1897, which modified the way images were cleared.
The viewpoints and intrinsics were correctly reset, but not followed by a request to update the graph. This meant that nodes' status was not updated (the cache for the CameraInit should be invalidated and propagated), and the filters in the Image Gallery were not all properly updated (in particular, the "Estimated Cameras" / "Non Estimated Cameras" were not reset.
A request to update the graph is now emitted after each attribute's reset.