[ui] 2D viewer: image sequence player #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mugulmd
force-pushed
the
mug/sequencePlayer
branch
from
20dd6d1
to
e8cc706
Compare
mugulmd
force-pushed
the
mug/sequencePlayer
branch
from
ba2d684
to
7b077c7
Compare
mugulmd
force-pushed
the
mug/sequencePlayer
branch
from
7b077c7
to
e928ef0
Compare
mugulmd
force-pushed
the
mug/sequencePlayer
branch
from
e928ef0
to
d852dc1
Compare
cbentejac
force-pushed
the
mug/sequencePlayer
branch
from
4134d79
to
5b2b431
Compare
cbentejac
requested changes
Jul 10, 2023
meshroom/ui/qml/Viewer/Viewer2D.qml
Outdated
| return getViewpointMetadata(_reconstruction.selectedViewId); | ||
| let vp = getViewpoint(_reconstruction.selectedViewId); | ||
| let metadata = vp ? vp.childAttribute("metadata").value : ""; | ||
| return JSON.parse(metadata); |
There was a problem hiding this comment.
Not exactly sure how it is triggered, but this line generates some SyntaxError: JSON.parse: Parse error as soon as a project is loaded, probably because the viewpoint (and thus the metadata) is not yet available at that point.
| target: _reconstruction | ||
| function onSelectedViewIdChanged() { | ||
| for (let idx = 0; idx < sortedViewIds.length; idx++) { | ||
| if (_reconstruction.selectedViewId == sortedViewIds[idx] && (m.frame != idx)) { |
There was a problem hiding this comment.
I think type coercion could be applied here:
Suggested change
| if (_reconstruction.selectedViewId == sortedViewIds[idx] && (m.frame != idx)) { | |
| if (_reconstruction.selectedViewId === sortedViewIds[idx] && (m.frame != idx)) { |
…antly updating selectedViewId
Implicitly defined slots in `Connections` are deprecated and should be replaced with functions.
mugulmd
force-pushed
the
mug/sequencePlayer
branch
from
97e27dd
to
73533cf
Compare
cbentejac
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new UI element in the 2D viewer: an image sequence player.
This player allows user to navigate smoothly between viewpoints and provides playback functionnalities.
For performance and interactivity purposes, this feature relies on a newly introduces image sequence cache in QtAliceVision: alicevision/QtAliceVision#36
Features list
SequencePlayercomponent with :pickedViewIdconcept inreconstructionsubordinated toselectedViewIdto allow only partial UI updates