[ui] Display an icon on nodes that have viewable 3D outputs #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
dev/imageSemanticIcon3D
branch
from
3efc9a7
to
f4bbb76
Compare
The tooltip that is displayed when hovering over the icon specifies which loader will be used, depending on the type of output attribute (either the Image/2D viewer, or the 3D viewer).
cbentejac
force-pushed
the
dev/imageSemanticIcon3D
branch
from
f4bbb76
to
b5638fe
Compare
fabiencastan
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows #2047 and extends the display of the icon for viewable outputs to outputs that are viewable in the 3D Viewer. Any
Fileoutput that has an extension supported by the 3D Viewer can be loaded.The distinction between outputs that can be loaded in the 2D Viewer and those that can be loaded in the 3D Viewer is made, and the tooltip that appears when hovering over the icon reflects that. The tooltip message has also been simplified.
The case where a node has both 2D and 3D outputs is handled with a corresponding tooltip message, although there is currently no such node.