Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noise reduction in HDR merging #2072

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Noise reduction in HDR merging #2072

merged 3 commits into from
Jul 5, 2023

Conversation

demoulinv
Copy link
Contributor

Description

Add option and parameters in LdrToHdrMerge node for advanced pixelwise HDR merging.

Features list

Implementation remarks

@demoulinv demoulinv mentioned this pull request Jun 19, 2023
Merged
4 tasks
@demoulinv demoulinv marked this pull request as ready for review June 28, 2023 14:10
@demoulinv demoulinv requested a review from cbentejac June 28, 2023 14:10
@mugulmd mugulmd added the invalidate:node Invalidates the cache of one or several nodes. label Jul 5, 2023
@mugulmd mugulmd added this to the Meshroom 2023.3.0 milestone Jul 5, 2023
@mugulmd
Copy link
Contributor

mugulmd commented Jul 5, 2023

Note

When merging RAW images with the HDR Fusion pipeline, better results are achieved with the Calibration Method and Working Color Space set to linear in the LdrToHdrSampling node.
It might be a good idea to use these as the default parameters in the future.

@mugulmd mugulmd merged commit 96ae35b into develop Jul 5, 2023
@mugulmd mugulmd deleted the dev/hdrMergingNoiseReduction branch July 5, 2023 10:15
@fabiencastan fabiencastan changed the title Advanced pixelwise merging Noise reduction in HDR merging Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mugulmd mugulmd mugulmd approved these changes

@fabiencastan fabiencastan Awaiting requested review from fabiencastan

@servantftechnicolor servantftechnicolor Awaiting requested review from servantftechnicolor

@cbentejac cbentejac Awaiting requested review from cbentejac

Assignees
No one assigned
Labels
invalidate:node Invalidates the cache of one or several nodes. majorFeature
Projects
None yet
Milestone
Meshroom 2023.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@demoulinv @mugulmd @fabiencastan