Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pixel aspect ratio (no UI) #2079

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Support pixel aspect ratio (no UI) #2079

merged 2 commits into from
Jul 3, 2023

Conversation

mugulmd
Copy link
Contributor

@mugulmd mugulmd commented Jun 23, 2023

Description

Full support of pixel aspect ratio in all the tools used for camera tracking.

related AliceVision PR: alicevision/AliceVision#1448

This PR is NOT about supporting non-trivial pixel aspect ratio in the UI.

Important

The SfMData file version was increased to 1.2.5 and this change impacts the viewpoints.sfm file generated when importing images in Meshroom.

@mugulmd mugulmd marked this pull request as ready for review June 29, 2023 08:17
@mugulmd mugulmd marked this pull request as draft June 29, 2023 08:38
@mugulmd mugulmd added invalidate:graph Invalidates the cache of the entire computation graph. and removed invalidate:graph Invalidates the cache of the entire computation graph. labels Jun 29, 2023
@mugulmd mugulmd marked this pull request as ready for review June 29, 2023 09:51
@cbentejac cbentejac merged commit a69104e into develop Jul 3, 2023
@cbentejac cbentejac deleted the mug/pixelRatio branch July 3, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants