Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codeFactor] add SEMANTIC enum for attribute description #2088

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[codeFactor] add SEMANTIC enum for attribute description #2088

wants to merge 1 commit into from

Conversation

almarouk
Copy link
Member

Semantic enum added for easier tracking of available and used semantics

@almarouk almarouk requested a review from cbentejac June 28, 2023 13:54
@cbentejac
Copy link
Contributor

This PR should not be merged until #1882 is merged.
With our current version of PySide2, enums cannot be exposed to QML (https://bugreports.qt.io/browse/PYSIDE-957). Rather than sending the enum values as integers, we shall wait until our version of PySide is updated so that enums can be exposed to QML.

@cbentejac
Copy link
Contributor

cbentejac commented Aug 1, 2023 •
edited
Loading

This is not as straightforward as I thought it would be, even with PySide2 5.15.2. I'm changing this PR's status to "Draft", we'll need to rework it.

@cbentejac cbentejac marked this pull request as draft August 1, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbentejac cbentejac Awaiting requested review from cbentejac

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almarouk @cbentejac