[ui] Check for the existence of the poses key in SfM JSON files before accessing it
#2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing the input JSON file, there might be some instances where the `poses` key, unlike the `views` and `intrinsics` keys, does not exist. If that is the case, an unhandled exception is raised while connections are being made, which then causes issues for the lifetime of the Meshroom instance. This commit checks that the key exists before trying to access it, which prevents raising unhandled exceptions while the active project is being set up.
fabiencastan
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When parsing the input SfM JSON file of a project, there might be some instances where the
poseskey, unlike theviewsandintrinsicskeys, does not exist. If that is the case, an unhandled exception is raised while connections are being made, which then causes issues for the lifetime of the Meshroom instance.This PR checks that the
poseskey exists before trying to access it, which prevents raising unhandled exceptions while the active project is being set up.