[Viewer3D] Add slider to display cameras based on their resection IDs #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any model with cameras is displayed in the 3D Viewer, a slider can be used to filter the cameras that are being currently displayed based on their resection IDs. This allows to visualize the order in which the cameras have been added, and the groups in which they have been added.
cbentejac
force-pushed
the
dev/resectionIdFiltering
branch
from
80b9f81
to
bd16d64
Compare
The `ExpandableGroup` is based on QML's `GroupBox`. It is very similar to the `Group` object, with the difference that it can be hidden/expanded by clicking on the group's title/label.
…evant The content of the "DISPLAY" and "CAMERA" groups is hidden by default. Instead of customizing the `Group` object's toolbar to hide/expand these groups, the `ExpandableGroup` object, which is specifically made to handle these cases, is used. The groups can be expanded either by clicking the dedicated tool button or anywhere on the toolbar.
Instead of displaying the resection IDs of the 3D model that was loaded last, update the display whenever the active model selection changes.
cbentejac
force-pushed
the
dev/resectionIdFiltering
branch
from
bd16d64
to
45b267a
Compare
fabiencastan
approved these changes
Nov 17, 2023
fabiencastan
added
the
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a slider in the 3D Viewer to filter cameras in the 3D view based on their resection IDs. The slider appears when the "Display Cameras Based On Resection IDs" button is selected, and if at least one of the objects currently loaded in the 3D Viewer has cameras with identifiable resection IDs.
Any camera whose resection ID is higher than the one set through the slider will be hidden the 3D view, which allows to visualize the order in which the cameras have been added, and the groups in which they have been added.
Additionally, the "DISPLAY" and "CAMERA" groups become tabs that can be expanded and hidden. By default, they are hidden.
This relates to alicevision/QtAliceVision#51 and alicevision/AliceVision#1593.