-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin System #2407
base: develop
Are you sure you want to change the base?
Plugin System #2407
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Could it be great to have "Delete Environment" button ? Like the "Delete Data" |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
added in todos for next version. Could be added to the "manage installed plugins" page, alongside the "un-install plugin" button |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
8a21540
to
61d8a15
Compare
ea95d40
to
b7f9a2f
Compare
66e7532
to
fab1b8e
Compare
0e26264
to
fa47004
Compare
added back menu after update fix for existing symlink
f98790b
to
24c4585
Compare
Would it be possible to add support for non-default location for conda environments? i.e. using "--prefix PATH" instead of "--name NAME". Meshroom/meshroom/core/plugin.py Line 90 in 24c4585
would become: cmd = condaBin+" list --prefix "+envName , or alternatively by checking the result of conda env list .
|
Description
This feature adds a plugin system to meshroom.
It also allows to install and run new nodes using containerization tools, such as conda and docker.
Features list
v1
v2
v3
Implementation remarks
The logic is in meshroom/core/plugin.py .
It defines a new node classes to run python code in environments/containers using meshroom_compute.
Added bandit file to not test the shell call errors in codefactor.
Uses the CI en var to skip the tests on CI.
Future needed work: ui part to list/uninstall catalog, multiples envs per node, button to delete env