Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite drag #993

Closed
wants to merge 0 commits into from
Closed

Infinite drag #993

wants to merge 0 commits into from

Conversation

ChemicalXandco
Copy link
Contributor

@ChemicalXandco ChemicalXandco commented Jul 19, 2020

Description

This adds an 'infinite drag' feature to the image viewer, 3D viewer and graph editor similar to that of Blender. This makes it much easier and quicker to drag the view around.

Implementation remarks

When the 3D view is being rotated, the rate at which it rotates relative to the amount the mouse is moving slows and eventually stops the further it is dragged, this behaviour happened before but it was not as noticeable because the drags were limited by the size of the screen. The way the drags going off the widget are handled is the cursor is moved to the opposite side and an offset is applied in order to compensate, as there is no way to stop the drag AFAIK. An alternative implementation that would be easier to handle but maybe less visually responsive is to hide the cursor and keep it in the same place while it is being dragged.

@fabiencastan
Copy link
Member

Hi @ChemicalXandco
I'm sorry I didn't test and check this PR. Do you plan to submit it differently or did you close it just because it was old (and without answer)?

@ChemicalXandco
Copy link
Contributor Author

@fabiencastan I plan to make another once #1227 is merged because I need to rework some things to make it compatible.

@ChemicalXandco ChemicalXandco deleted the infinite_drag branch January 18, 2021 10:31
@fabiencastan
Copy link
Member

Ok, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants