Fix for #27: support negative indexing of sections.

alisaifee · Nov 2, 2014 · 4843475 · 4843475
1 parent e128c16
commit 4843475
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/holmium/core/pageobject.py b/holmium/core/pageobject.py
@@ -588,6 +588,8 @@ def __len__(self):
         return len(self.__getelements__())
 
     def __getitem__(self, idx):
+        if idx < 0:
+            idx = len(self) + idx
         if idx < 0 or idx >= len(self):
             raise IndexError("Sections index (%d) out of range" % idx)
         for i, _ in enumerate(self):

diff --git a/tests/sectionobject_tests.py b/tests/sectionobject_tests.py
@@ -169,4 +169,13 @@ def test_sections_list_behavior(self):
             self.assertEqual("element 4", po.sections[0].tokens[1].text)
             self.assertEqual("element 3", po.sections[1].tokens[1].text)
             self.assertEqual("element 6", po.sections[2].tokens[1].text)
-
+            self.assertEqual("element 6", po.sections[-1].tokens[1].text)
+            self.assertEqual("element 3", po.sections[-2].tokens[1].text)
+            self.assertRaises(
+                IndexError,
+                lambda: po.sections[-4]
+            )
+            self.assertRaises(
+                IndexError,
+                lambda: po.sections[3]
+            )