Prevent deadlock when purging idle worker during task submission #34
Conversation
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 4 +1
Lines 376 394 +18
=========================================
+ Hits 376 394 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| assertEqual(t, 1, pool.IdleWorkers()) | ||
|
|
||
| // Stop an idle worker right before submitting another task | ||
| pool.maybeStopIdleWorker() |
There was a problem hiding this comment.
Thanks for this PR and the prompt reaction!
How does this test validate issue #33, if maybeStopIdleWorker is synchronously called by the same go routine?
There was a problem hiding this comment.
This test was entering a deadlock quite consistently (although not 100% of the time). maybeStopIdleWorker executes synchronously up to this point, where it sends a nil task to kill a worker goroutine asynchronously (buffered channel). In the previous version of the lib, the idle worker counter was being updated when the killed goroutine exited, so there was a small window of time during which this call would incorrectly return false, indicating there was an idle worker available.
workerfunction to make it simpler and more genericworkerfunction to a separate fileMakefilewith test targets