fix: add contributions #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berkmann18
approved these changes
Oct 18, 2019
|
🎉 This PR is included in version 6.9.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Berkmann18
pushed a commit
that referenced
this pull request
May 24, 2020
* chore(package): update serverless-offline to version 5.0.0 * chore(package): update lockfile yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix issue #209. The problem was that an
undefinedentity (argv._[1]) became a string with a value of"undefined".How:
I simply check if the value is undefined if it is not then I convert it to a string otherwise it stays an
undefinedvalue.Checklist:
I don't usually program in JS, let me know if there is a more idiomatic way to make this change.