Show a helpful message when .all-contributorsrc doesn't exist. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this be tested? |
|
LGTM |
jfmengels
requested changes
Oct 16, 2016
| }); | ||
|
|
||
| test.cb('Writing contributors in an absent configuration file throws a helpful error', t => { | ||
| t.plan(1); |
There was a problem hiding this comment.
No need for t.plan, the test will fail unless t.end is called anyway.
There was a problem hiding this comment.
You're right. Thanks!
| configFile.readConfig(absentFile); | ||
| }).message, | ||
| expected | ||
| ); |
There was a problem hiding this comment.
You can simplify this like the following:
t.throws(() => {
configFile.readConfig(absentFile);
}, expected);because t.throws already takes an optional parameter allowing to verify the message of the error. See https://github.com/avajs/ava#throwsfunctionpromise-error-message
jfmengels
approved these changes
Oct 17, 2016
|
Thanks a lot @fadc80! :) |
|
I published this in v3.0.7. |
Berkmann18
pushed a commit
that referenced
this pull request
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement first item of issue #6