-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency dirs for monorepo config #647
Add dependency dirs for monorepo config #647
Conversation
@bgalek WDYT |
Adding a comment I added in #326 to provide some background: We are moving away to use composite build, as a result when a dependency project gets updated, the main project stays on the same version, this created all sorts of problems for us so we reverted, I opened a new PR #647 that is actually continuing the work I did in #422 to make monorepos work (closed #332) |
@bgalek WDYT? |
@bgalek please let me know what you think :) |
@shashken ok, lets do it, could you just rebase this PR? |
…or_monorepo_config # Conflicts: # build.gradle # src/main/java/pl/allegro/tech/build/axion/release/domain/VersionResolver.java # src/main/java/pl/allegro/tech/build/axion/release/domain/properties/MonorepoProperties.java
thanks! @bgalek working on it, we are also currently working with java 8 on a single project, is it possible to release this for older java version as well as a hotfix? I saw that latest versions removed support for older java versions |
@shashken we could backport, but I really don't like the idea, jdk8 is dead to me ;) |
lol @bgalek as it should be 😄 but sadly not for us just yet 😢 |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #647 +/- ##
============================================
- Coverage 60.74% 60.46% -0.28%
Complexity 387 387
============================================
Files 81 81
Lines 1531 1538 +7
Branches 143 146 +3
============================================
Hits 930 930
- Misses 532 537 +5
- Partials 69 71 +2
|
I would recommend a fork then, I don't want to manage two versions at the same time (v2), and this is a new feature not fixing a bug, sorry |
Ok so this one is ready from my side |
thank you for understanding and your collaboration! |
@shashken please also upadate documentation |
… `exclude` parameter
@bgalek Added |
@shashken nice! |
@bgalek added a test, this branch was opened 1.5 months ago, I am loosing a lot of context here, lets aim for short living branches and move the rename to a different issue/PR |
Sure, we can |
Add the option to configure several dependency directories to affect the version in a monorepo project