Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Gradle to 6.5.* (or newer) to show correct Lua test names #140

Closed
MarcinFalkowski opened this issue Jul 15, 2020 · 0 comments
Closed

Upgrade Gradle to 6.5.* (or newer) to show correct Lua test names #140

MarcinFalkowski opened this issue Jul 15, 2020 · 0 comments
Assignees
@pzmi

Comments

@MarcinFalkowski
Copy link
Contributor

There is a bug in Gradle because of which we don't see correct names of Lua tests in the output.
Upgrading Gradle to 6.5.* should fix it.
We probably also need to upgrade kotlin before upgrading Gradle, so this issue is blocked by #102

Details of our problem is described here: https://github.com/allegro/envoy-control/pull/139/files#r453732945
More info about the bug in gradle:
deejay1 added a commit to deejay1/envoy-control that referenced this issue Sep 22, 2020
@deejay1
Bump gradle and kotlin
8fdea94 
Fixes issues allegro#102 and allegro#140.
@deejay1 deejay1 mentioned this issue Sep 22, 2020
Merged
@pzmi pzmi self-assigned this Oct 1, 2020
pzmi pushed a commit that referenced this issue Oct 2, 2020
@deejay1
Bump gradle and kotlin (#175)
b10a8e9 
* Bump gradle and kotlin

Fixes issues #102 and #140.

* Fixup detekt and ktlint configuration

* Ooops, merged the wrong way
pzmi pushed a commit that referenced this issue Oct 6, 2020
@deejay1
Bump detekt version (#176)
43d51f5 
* Bump gradle and kotlin

Fixes issues #102 and #140.

* Fixup detekt and ktlint configuration

* Upgrade detekt and adapt some code to new rules

* Fixup excludes
@pzmi pzmi closed this as completed Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pzmi pzmi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pzmi @MarcinFalkowski