#96 Improve takeSnapshot
#97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgalek
reviewed
Sep 17, 2024
| @@ -5,6 +5,17 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [2.5.0] - 2024-09-17 | |||
There was a problem hiding this comment.
you can remove the changelog, we're using github releases for release notes ;)
jedlikowski
reviewed
Sep 18, 2024
| setTimeout(() => this.takeSnapshot(), 500); | ||
| return new Promise((resolve) => { | ||
| // There might not be available worker, let it start. | ||
| setTimeout(() => resolve(this.takeSnapshot()), 500); |
There was a problem hiding this comment.
shouldn't we pass the same options to the second call?
Suggested change
| setTimeout(() => resolve(this.takeSnapshot()), 500); | |
| setTimeout(() => resolve(this.takeSnapshot(options)), 500); |
| if (callback) { callback('heap snapshot done'); } | ||
| }); | ||
| const getHeapSnapshot = (callback) => { | ||
| if (hasEnoughMemory()) { |
There was a problem hiding this comment.
How about an early return if not enough memory to avoid having the main function body enclosed in an if statement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves takeSnapshot method