(v2.0) Strict mode by default #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 17, 2022
KostkaBrukowa
approved these changes
Jan 17, 2022
| ) => | ||
| allFilePaths.filter( | ||
| (filePath) => | ||
| !isFileStrictByPath(filePath, configPaths) && !filePathsWithErrors.includes(filePath), |
There was a problem hiding this comment.
i think that if we would convert filePathsWithErrors to set before filtering it could be a littlebit faster, but i dont know if its worth optimizing
There was a problem hiding this comment.
Set doesn't have a filter method unfortunately
There was a problem hiding this comment.
I was talking about something like this
export const getFilePathsWithoutErrors = (
allFilePaths: string[],
filePathsWithErrors: string[],
configPaths?: string[],
) => {
const filePathsWithErrorsSet = new Set(filePathsWithErrors);
return allFilePaths.filter(
(filePath) =>
!isFileStrictByPath(filePath, configPaths) && !filePathsWithErrorsSet.has(filePath),
);
}
|
Hello @kamkry and @KostkaBrukowa! |
|
Hi @aleksandrlat, we've just published it with version |
|
Awesome! Thank you @kamkry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that adding strict mode manually was not enough for project migration due to simply forgetting to add it in new files or in changed ones. The new version will enable strict mode by default (no need for ts-strict comment) and ignore it in a specific file one can add //@ts-strict-ignore at the top of a file. With that design new files automatically come with strict mode enabled and it's easier to notice ignored files when modifying them, encouraging to try to fix those errors.
What about migration?
The 2.0 version will come with a CLI tool that will automatically detect files with strict errors and add ignore comments to them. It will also remove unnecessary strict comments existing in the project.
The PR also introduces a major refactor, unifying the strict file detection between CLI tools and the TS plugin.
Tasks left