hf_olmo modeling class should be a true PreTrainedModel
#391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
reviewed
Dec 7, 2023
hamishivi
reviewed
Dec 8, 2023
| def tie_weights(self): | ||
| if self.config.weight_tying: | ||
| self.model.transformer.ff_out = self.model.transformer.wte | ||
|
|
||
|
|
||
| # Register the model so that it is available for transformer pipelines, auto-loading, etc. | ||
| AutoModelForCausalLM.register(OLMoConfig, OLMoForCausalLM) |
There was a problem hiding this comment.
Have you tested multi-gpu loading? e.g.
AutoModelForCausalLM.from_pretrained(..., device_map='balanced') with multiple GPUs available?
And does generation work fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for loading and finetuning further.
There is some degree of code repetition between olmo and hf_olmo which I would have liked to avoid, but it was leading to odd issues in loading the state dict.