Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage Cleaner] Improvements to moving runs #493

Merged
merged 4 commits into from
Mar 9, 2024

Conversation

2015aroras
Copy link
Collaborator

This is the first of 3 PRs that make changes to the move mechanism of the storage cleaner. The other PRs will:

  1. Add the option to move just 1 entry from a run, making the script more parallelizable.
  2. Migrate off TrainConfig to support legacy checkpoints.

This PR makes the following changes:

  • Adds most of the functionality for moving non-checkpoint entries when append_wandb_path is set. This will make it possible to upload train_data to all folders that need it.
  • Lets the storage adapter choose what happens when moving an entry to a destination where the entry already exists. This change is not necessary but is convenient.

@2015aroras 2015aroras requested a review from epwalsh March 8, 2024 23:08
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2015aroras 2015aroras merged commit c2840e4 into main Mar 9, 2024
10 checks passed
@2015aroras 2015aroras deleted the shanea/storage-cleaner-move-improvements branch March 9, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants