[Storage Cleaner] Move 1 entry within a run directory #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
approved these changes
Mar 11, 2024
scripts/storage_cleaner.py
Outdated
| move_parser.add_argument( | ||
| "--entry", | ||
| default=None, | ||
| help="If provided, moving is restricted to this entry of the run.", |
There was a problem hiding this comment.
Maybe add a few words here to describe how an --entry should be specified. For example it looks it should be given as a filename without any other path components?
scripts/storage_cleaner.py
Outdated
| src_dest_pairs = [ | ||
| src_dest_pair | ||
| for src_dest_pair in src_dest_pairs | ||
| if Path(src_dest_pair[0]).name == config.entry.rstrip("/") |
There was a problem hiding this comment.
This seems a little bit brittle, what about:
Suggested change
| if Path(src_dest_pair[0]).name == config.entry.rstrip("/") | |
| if str(Path(src_dest_pair[0])).endswith(str(Path(config.entry))) |
Do we warn anywhere if this list comes up empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to move a single entry (file or directory) from a run to another location. This can be run in parallel for all entries run to get higher throughput.