Move tokenizers to new olmo_data package.
#645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
approved these changes
Jul 8, 2024
olmo_data/data.py
Outdated
|
|
||
|
|
||
| @contextmanager | ||
| def get_data_path(data_rel_path: str) -> Iterator[Path]: |
There was a problem hiding this comment.
I think the correct return type is:
Suggested change
| def get_data_path(data_rel_path: str) -> Iterator[Path]: | |
| def get_data_path(data_rel_path: str) -> Generator[Path, None, None]: |
There was a problem hiding this comment.
The python docs say
If your generator will only yield values, set the SendType and ReturnType to None:
...
Alternatively, annotate your generator as having a return type of either Iterable[YieldType] or Iterator[YieldType]:
🤷
There was a problem hiding this comment.
I'm with it either way. Your way is less verbose so that's a plus.
|
@2015aroras Could we add something which doesn't break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Tokenizer.from_checkpointassumes that tokenizers are in HF or in a path relative to the current directory. This assumption doesn't hold when OLMo is install from pip asai2-olmo. More generally, we don't have a clear mechanism for putting data files in our repo.Fix: This PR creates an
olmo_datapackage, of which the subdirectories can correspond to various types of data (e.g.tokenizersandhf_datasets). Tokenizers are moved underolmo_data, andTokenizer.from_checkpointis updated to look at local paths, thenolmo_data, then HF Hub.This change sets up the foundations for adding HF datasets to our repo, so that we don't have to make network calls during training runs.
Fixes #633