Add ability to save and compare sub-module outputs #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2015aroras
changed the title
epwalsh
approved these changes
Aug 12, 2024
olmo/config.py
Outdated
| @@ -1217,6 +1217,11 @@ class TrainConfig(BaseConfig): | |||
| Path to cache directory of HF datasets saved with `datasets.save_to_disk`. | |||
| """ | |||
|
|
|||
| module_outputs_save_steps: Optional[List[int]] = None | |||
| """ | |||
| Outputs of model submodules are saved during the provided steps. | |||
There was a problem hiding this comment.
Can you add a note here about how to use the script to view the results?
There was a problem hiding this comment.
81c07c6 I've mentioned the script for now. I intend to add a doc describing debugging with this soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to save and compare sub-module outputs. This was helpful for finding the fix in #680. We could use this functionality as part of an integration test in the future.