Skip to content
This repository has been archived by the owner on Jan 20, 2023. It is now read-only.

Ordered RC examples #896

Merged
merged 27 commits into from
Mar 26, 2021
Merged

Ordered RC examples #896

merged 27 commits into from
Mar 26, 2021

Conversation

dirkgr
Copy link
Member

@dirkgr dirkgr commented Mar 18, 2021 •
edited
Loading

This makes it so examples for the reading comprehension tasks are ordered the way they appear in the tasks file. At least, that's what it'll do when it's done.

This is part of a multi-repo nightmare. We need

all at the same time.

@dirkgr
Make Vilbert VQA refer to the right model
5b43ab1
@dirkgr
Don't say tagging
1e09d59
@dirkgr
Newer version of allennlp and allennlp-models
3fecffc
@dirkgr
Update the way VilBERT runs
4c930cd
@dirkgr
Merge remote-tracking branch 'origin/master' into DemoModelSweep
b32fe68
@dirkgr
Merge remote-tracking branch 'origin/master' into DemoModelSweep
56b272c
@dirkgr
Print output during docker build
e2afe86
@dirkgr
Upgrade version of allennlp
581ab20
@dirkgr
Merge remote-tracking branch 'origin/master' into DemoModelSweep
dc58bf4
@dirkgr
Upgrade to 2.x
8c48c56
@dirkgr
Print output during docker build
fb17824
@dirkgr
Update model cards
5de2e91
@dirkgr
Merge branch 'SweepNotBrokenDammit' into DemoModelSweep
e9456d1
@dirkgr
Merge remote-tracking branch 'origin/master' into DemoModelSweep
3b864fe
@dirkgr
Removes semantic parsing stuff
5a32efa
@dirkgr
Update -models to fix coref
4ebac8e
@dirkgr
Updates version of -models
440fa00
@dirkgr
Fixes ./demo so that it behaves correctly while not capturing the out…
540e64e 
…put form `docker build`
@dirkgr
Merge remote-tracking branch 'origin/master' into DemoModelSweep
419812b
@dirkgr
Revert "Removes semantic parsing stuff"
cc8e751 
This reverts commit 5a32efa.
@dirkgr
Makes the semantic parsing models work again
e4e2524 
They have no UI though. This is just the backend.
@dirkgr
Hopefully fixes the atis_parser test
0ddd3db
@dirkgr
Fix nlvr_parser and wikitables_parser too
a140d36
@dirkgr
Copy link
Member Author

dirkgr commented Mar 18, 2021

@jonborchardt, this currently stalls out when trying to read the response from the tasks service, as expected. The format is actually defined in tugboat, not here.

This was referenced Mar 18, 2021
Merged
Merged
@codeviking
Copy link
Contributor

codeviking commented Mar 18, 2021 •
edited
Loading

The format is actually defined in tugboat, not here.

Maybe we should move the definition to back to the AllenNLP demo. I'm not sure it makes sense to live in Tugboat, given it's an AllenNLP specific thing.

@jonborchardt what do you think?

@codeviking
Copy link
Contributor

codeviking commented Mar 18, 2021 •
edited
Loading

@dirkgr I'm not seeing an error when I pull this down and run things locally...but the examples for RC appear to be in the same order as they're in now. So either I'm doing something wrong, or there's an uncommitted change or some other ghost in the machine somewhere in the mix?

@dirkgr
Copy link
Member Author

dirkgr commented Mar 18, 2021

Sorry, I had some untracked files in the directory.

codeviking and others added 2 commits March 18, 2021 11:12
@codeviking
Add support for categorized examples. (#897)
5fe66d8 
This adds support to the UI for the new example format, which
required updating to `@allenai/varnish@2.0.0` and patching some
related code.
@dirkgr
Merge remote-tracking branch 'origin/master' into OrderedRcExamples
812e5c6
@dirkgr
Copy link
Member Author

dirkgr commented Mar 25, 2021

I ran this just now and it worked right away. I don't know why I thought it was broken before. Will now try to orchestrate the reviews across three repos 🤪.

@dirkgr dirkgr marked this pull request as ready for review March 25, 2021 18:10
@dirkgr
Copy link
Member Author

dirkgr commented Mar 25, 2021

I'm getting this Cypress error. Apparently it can't find the description for reading comprehension tasks in the output of the main page.

When I curl, I just get a warning that I need to enable JavaScript. When I pull the main page with a browser, the description of RC tasks is there. I am not sure how to proceed. What is Cypress actually doing?

@codeviking
Copy link
Contributor

Did the text change?

The test loads the page in a browser, and looks for the text that's defined here.

If the text is present but this isn't finding it, then something else is wrong. If the text changed we might just need to update
that string.

I'll try this out shortly and let you know what I figure out.

@codeviking
Copy link
Contributor

It appears to be something that's CI specific, as they work locally. I cut #903, someone from ReViz will look into this next week, but for now it's ok to ignore the failures as they're spurious.

@dirkgr dirkgr merged commit 658f0e4 into master Mar 26, 2021
@dirkgr dirkgr deleted the OrderedRcExamples branch March 26, 2021 22:26
@dirkgr
Copy link
Member Author

dirkgr commented Mar 26, 2021

Sweet, it's live and it works!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkgr @codeviking