Update nltk requirement from <3.6.5 to <3.6.6 (#307)

* Update nltk requirement from <3.6.5 to <3.6.6 Updates the requirements on [nltk](https://github.com/nltk/nltk) to permit the latest version. - [Release notes](https://github.com/nltk/nltk/releases) - [Changelog](https://github.com/nltk/nltk/blob/develop/ChangeLog) - [Commits](nltk/nltk@2.0.1rc1...3.6.5) --- updated-dependencies: - dependency-name: nltk dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * NLTK no longer splits tokens for us * Now we _have_ to have the most recent version * CHANGELOG.md Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dirk Groeneveld <[email protected]>
allenai · Nov 12, 2021 · 05dd4e6 · 05dd4e6
1 parent 6c4daca
commit 05dd4e6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+### Changed
+
+- Following a breaking change in the NLTK API, we now depend on the most recent version only.
+
+
 ## [v2.8.0](https://github.com/allenai/allennlp-models/releases/tag/v2.8.0) - 2021-11-05
 
 ### Changed

diff --git a/allennlp_models/rc/tools/narrativeqa.py b/allennlp_models/rc/tools/narrativeqa.py
@@ -37,7 +37,7 @@ def bleu_4(p, g):
 
 
 def meteor(p, g):
-    return meteor_score(g, p)
+    return meteor_score([x.split() for x in g], p.split())
 
 
 def rouge_l(p, g):

diff --git a/requirements.txt b/requirements.txt
@@ -8,7 +8,7 @@ conllu==4.4.1
 # For RC models
 word2number>=1.1
 py-rouge==1.1
-nltk<3.6.5
+nltk>=3.6.5
 
 # For CNN/DailyMail dataset reader
 ftfy