Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Add T5 for generation/summarization #241

Merged
merged 9 commits into from
Apr 22, 2021
Merged

Add T5 for generation/summarization #241

merged 9 commits into from
Apr 22, 2021

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Mar 31, 2021

No description provided.

@epwalsh epwalsh changed the title add T5 CNN / DM config Add T5 for generation/summarization Apr 1, 2021
epwalsh
epwalsh commented Apr 1, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
epwalsh
epwalsh commented Apr 1, 2021
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
@epwalsh epwalsh mentioned this pull request Apr 1, 2021
Merged
@epwalsh epwalsh requested a review from dirkgr April 1, 2021 17:56
@epwalsh epwalsh marked this pull request as ready for review April 1, 2021 17:56
dirkgr
dirkgr suggested changes Apr 22, 2021
View reviewed changes
Copy link
Member

@dirkgr dirkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can get away without having a tokenizer in the model.

allennlp_models/generation/models/t5.py Show resolved Hide resolved
@epwalsh epwalsh merged commit 7a6ee0c into main Apr 22, 2021
@epwalsh epwalsh deleted the t5-config branch April 22, 2021 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dirkgr dirkgr dirkgr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epwalsh @dirkgr