Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Add best span probs #244

Merged
merged 7 commits into from
Apr 6, 2021
Merged

Add best span probs #244

merged 7 commits into from
Apr 6, 2021

Conversation

jacob-morrison
Copy link
Contributor

@jacob-morrison jacob-morrison commented Apr 6, 2021

Adding span probabilities to TransformerQA's output to address allenai/allennlp#4465

@jacob-morrison jacob-morrison marked this pull request as ready for review April 6, 2021 02:38
@dirkgr
Copy link
Member

dirkgr commented Apr 6, 2021

If you reference allenai/allennlp#4465 in the description, merging this PR will auto-close the issue.

allennlp_models/rc/models/transformer_qa.py Outdated Show resolved Hide resolved
tests/rc/models/transformer_qa_test.py Show resolved Hide resolved
@jacob-morrison
Copy link
Contributor Author

If you reference allenai/allennlp#4465 in the description, merging this PR will auto-close the issue.

Can it auto-close that issue if it's technically in a different repository?

@dirkgr
Copy link
Member

dirkgr commented Apr 6, 2021

Can it auto-close that issue if it's technically in a different repository?

Oh, right. I guess it cannot. Otherwise it would show up now on the right under "linked issues".

@dirkgr
Copy link
Member

dirkgr commented Apr 6, 2021

Sweet, ship it!

@dirkgr
Copy link
Member

dirkgr commented Apr 6, 2021

aba8e5e1555d2354a7233de495cb33e9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants