This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Making TransformerQAPredictor compatible with interpret modules #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkshitaB
commented
Apr 13, 2021
| raise NotImplementedError( | ||
| "This predictor maps a question to multiple instances. " | ||
| "Please use _json_to_instances instead." | ||
| logger.warning( |
There was a problem hiding this comment.
@dirkgr I'm not sure if just adding a warning instead of an error actually breaks anything.
There was a problem hiding this comment.
I don't think it breaks anything, but people don't read warnings.
dirkgr
approved these changes
Apr 14, 2021
| raise NotImplementedError( | ||
| "This predictor maps a question to multiple instances. " | ||
| "Please use _json_to_instances instead." | ||
| logger.warning( |
There was a problem hiding this comment.
I don't think it breaks anything, but people don't read warnings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
predictions_to_labeled_instancesand_json_to_instance.Fixes allenai/allennlp-demo#679