Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Distributed metrics #251

Merged
merged 6 commits into from
Apr 19, 2021
Merged

Distributed metrics #251

merged 6 commits into from
Apr 19, 2021

Conversation

AkshitaB
Copy link
Contributor

ArjunSubramonian
ArjunSubramonian approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@ArjunSubramonian ArjunSubramonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM - I didn't even know that dict_reduce_sum existed

@AkshitaB AkshitaB merged commit e5789cf into main Apr 19, 2021
@AkshitaB AkshitaB deleted the distributed-metrics branch April 19, 2021 07:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ArjunSubramonian ArjunSubramonian ArjunSubramonian approved these changes

@dirkgr dirkgr Awaiting requested review from dirkgr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure that metrics in allennlp-models work in the distributed setting
2 participants
@AkshitaB @ArjunSubramonian