Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Remove registered_predictor_name from all modelcards where the predictor is the same as the default #253

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Remove registered_predictor_name from all modelcards where the predictor is the same as the default #253

merged 3 commits into from
Apr 19, 2021

Conversation

AkshitaB
Copy link
Contributor

@AkshitaB AkshitaB requested a review from dirkgr April 19, 2021 06:26
dirkgr
dirkgr approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@dirkgr dirkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those the only cases? I thought this would be the case for virtually all the models?

allennlp_models/modelcards/ve-vilbert.json
@@ -1,7 +1,7 @@
{
"id": "ve-vilbert",
"registered_model_name": "visual-entailment",
"registered_predictor_name": "vilbert_ve",
"registered_model_name": "ve_vilbert",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@AkshitaB AkshitaB merged commit d18c837 into main Apr 19, 2021
@AkshitaB AkshitaB deleted the fix-model-cards branch April 19, 2021 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dirkgr dirkgr dirkgr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove registered_predictor_name from all modelcards where the predictor is the same as the default
2 participants
@AkshitaB @dirkgr