This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is an impressive commit history! |
epwalsh
reviewed
Jun 2, 2021
"Impressive" for sure! Lots of commit -> pull down on allennlp-server4 -> test -> repeat |
epwalsh
reviewed
Jun 2, 2021
Co-authored-by: Pete <[email protected]>
epwalsh
reviewed
Jun 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! Just a few more comments / questions
Co-authored-by: Pete <[email protected]>
Co-authored-by: Pete <[email protected]>
Co-authored-by: Pete <[email protected]>
epwalsh
reviewed
Jun 4, 2021
epwalsh
approved these changes
Jun 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for NLVR2 (https://lil.nlp.cornell.edu/nlvr/, https://api.semanticscholar.org/CorpusID:53178856), including a dataset reader and two models (a standalone model and a multitask model head)