Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Nlvr2 #265

Merged
merged 110 commits into from
Jun 4, 2021
Merged

Nlvr2 #265

merged 110 commits into from
Jun 4, 2021

Conversation

jacob-morrison
Copy link
Contributor

@jacob-morrison jacob-morrison commented May 18, 2021

Adding support for NLVR2 (https://lil.nlp.cornell.edu/nlvr/, https://api.semanticscholar.org/CorpusID:53178856), including a dataset reader and two models (a standalone model and a multitask model head)

@jacob-morrison jacob-morrison marked this pull request as ready for review June 2, 2021 18:37
@epwalsh
Copy link
Member

epwalsh commented Jun 2, 2021

That is an impressive commit history!

CHANGELOG.md Outdated Show resolved Hide resolved
@jacob-morrison
Copy link
Contributor Author

That is an impressive commit history!

"Impressive" for sure! Lots of commit -> pull down on allennlp-server4 -> test -> repeat

allennlp_models/vision/dataset_readers/nlvr2.py Outdated Show resolved Hide resolved
allennlp_models/vision/dataset_readers/nlvr2.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! Just a few more comments / questions

allennlp_models/modelcards/nlvr2-vilbert-head.json Outdated Show resolved Hide resolved
allennlp_models/modelcards/nlvr2-vilbert.json Outdated Show resolved Hide resolved
allennlp_models/vision/dataset_readers/nlvr2.py Outdated Show resolved Hide resolved
allennlp_models/modelcards/nlvr2-vilbert.json Outdated Show resolved Hide resolved
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacob-morrison jacob-morrison enabled auto-merge (squash) June 4, 2021 22:37
@jacob-morrison jacob-morrison merged commit 664f38f into main Jun 4, 2021
@jacob-morrison jacob-morrison deleted the nlvr2 branch June 4, 2021 22:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants