Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Pass vocab to beam search #288

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Pass vocab to beam search #288

merged 2 commits into from
Jul 19, 2021

Conversation

JohnGiorgi
Copy link
Contributor

@JohnGiorgi JohnGiorgi commented Jul 19, 2021 •
edited
Loading

This is a small PR that should be considered alongside allenai/allennlp#5321. It just passes vocab to all the beam_search.construct calls in the generation models.

@JohnGiorgi JohnGiorgi mentioned this pull request Jul 19, 2021
Merged
6 tasks
epwalsh
epwalsh approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@epwalsh epwalsh merged commit 146ea76 into allenai:main Jul 19, 2021
@JohnGiorgi JohnGiorgi deleted the pass-vocab-to-beam-search branch July 19, 2021 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@epwalsh epwalsh epwalsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnGiorgi @epwalsh