This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
IMDB Model #297
Merged
IMDB Model #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkshitaB
reviewed
Aug 23, 2021
|
|
||
|
|
||
| @Model.register("transformer_classification_tt") | ||
| class TransformerClassificationTransformerToolkit(Model): |
There was a problem hiding this comment.
That's a verbose name! :) Is there a reason to name models that use the transformer toolkit thus?
There was a problem hiding this comment.
I did it this way for the "MC" models, and I wanted to stay consistent. But "MC" is much shorter than "Classification", so now it looks silly.
We could rename all the Transformer Toolkit models to just "TT"? Then we also don't have to say "Transformer" twice.
AkshitaB
approved these changes
Aug 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will need this for DSPT.
This depends on allenai/allennlp#5372 being merged.