This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Fix the IndexError when CNNDailyMailDatasetReader reads test data.
#306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
IndexErrorhappens when the first line of a text file only contains(CNN). This happens for reading test data of CNN news.Example: You can check this file in the extracted
cnn_storiesdirectory:12078b09d95c01cedb06da7fc63faab540432dee.story.This file would be read for test data (corresponding to this URL in all_text.txt`: http://web.archive.org/web/20150617021105id_/http://www.cnn.com/2015/04/16/opinions/medical-marijuana-revolution-sanjay-gupta/)
Note: the provided training config does not evaluate on test data. So this error could be ignored in this case.
Solution: remove "(CNN)" before checking the empty string