Run some slow tests on the self-hosted runner (#5161)

* make checklist test run faster

* mark some more tests as GPU

* move t5 download

tests/commands/checklist_test.py

@@ -3,7 +3,7 @@
 
 from allennlp.commands import main
 from allennlp.commands.checklist import CheckList
-from allennlp.common.testing import AllenNlpTestCase
+from allennlp.common.testing import AllenNlpTestCase, requires_gpu
 
 
 class TestCheckList(AllenNlpTestCase):
@@ -39,6 +39,8 @@ def test_add_checklist_subparser(self):
         assert args.output_file == "/dev/null"
         assert args.cuda_device == 0
 
+    # Mark this as GPU so it runs on a self-hosted runner, which will be a lot faster.
+    @requires_gpu
     def test_works_with_known_model(self):
 
         sys.argv = [
@@ -48,6 +50,10 @@ def test_works_with_known_model(self):
             str(self.task),
             "--task-suite-args",
             '{"positive": 1, "negative": 0}',
+            "--max-examples",
+            "1",
+            "--cuda-device",
+            "0",
         ]
 
         main()

tests/common/file_utils_test.py

@@ -599,9 +599,8 @@ def test_cached_download_no_user_or_org(self):
         assert meta.resource == "hf://t5-small/config.json"
 
     def test_snapshot_download_no_user_or_org(self):
-        path = cached_path("hf://t5-small", cache_dir=self.TEST_DIR)
+        path = cached_path("hf://t5-small")
         assert os.path.isdir(path)
-        assert pathlib.Path(os.path.dirname(path)) == self.TEST_DIR
         assert os.path.isfile(path + ".json")
         meta = _Meta.from_path(path + ".json")
         assert meta.resource == "hf://t5-small"

tests/modules/transformer/t5_test.py

@@ -2,8 +2,11 @@
 from transformers.models import t5 as hf_t5
 
 from allennlp.modules.transformer.t5 import T5
+from allennlp.common.testing import requires_gpu
 
 
+# Mark this as GPU so it runs on a self-hosted runner, which will be a lot faster.
+@requires_gpu
 @pytest.mark.parametrize(
     "pretrained_model_name",
     [

tests/sanity_checks/task_checklists/sentiment_analysis_suite_test.py

@@ -1,5 +1,5 @@
 from allennlp.sanity_checks.task_checklists.sentiment_analysis_suite import SentimentAnalysisSuite
-from allennlp.common.testing import AllenNlpTestCase
+from allennlp.common.testing import AllenNlpTestCase, requires_gpu
 from allennlp.models.archival import load_archive
 from allennlp.predictors import Predictor
 
@@ -12,6 +12,8 @@ def setup_method(self):
         )
         self.predictor = Predictor.from_archive(archive)
 
+    # Mark this as GPU so it runs on a self-hosted runner, which will be a lot faster.
+    @requires_gpu
     def test_run(self):
         data = [
             "This is really good",
@@ -22,4 +24,4 @@ def test_run(self):
             "I have visited the place for 3 years; great food!",
         ]
         suite = SentimentAnalysisSuite(add_default_tests=True, data=data)
-        suite.run(self.predictor, max_examples=10)
+        suite.run(self.predictor, max_examples=1)