Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

[NOT FOR MERGING] Transfer learning bug #4209

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jacobdanovitch
Copy link
Contributor

MWE to (sort of) reproduce #4205. Invoke with pytest -sk TransferLearningTest.

@epwalsh
Copy link
Member

epwalsh commented May 8, 2020

Hey @jacobdanovitch, is it necessary that this test depends on models/readers from allennlp_models? We would like to avoid having allennlp depend on allennlp_models. And could you fix the linting errors? https://github.com/allenai/allennlp/pull/4209/checks

@matt-gardner
Copy link
Contributor

@epwalsh, I'm on this one. This was to give me a minimal error that would help me diagnose #4205. This is not for merging in its current state.

@matt-gardner matt-gardner self-assigned this May 8, 2020
@matt-gardner
Copy link
Contributor

Closing, as this didn't end up being a bug on our end. See here.

@matt-gardner matt-gardner reopened this May 15, 2020
@matt-gardner matt-gardner changed the title Transfer learning bug [NOT FOR MERGING] Transfer learning bug May 15, 2020
@schmmd schmmd changed the base branch from master to main December 23, 2020 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants