Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Fixes token type ids for folded sequences #5149

Merged
merged 6 commits into from
Apr 26, 2021
Merged

Fixes token type ids for folded sequences #5149

merged 6 commits into from
Apr 26, 2021

Conversation

dirkgr
Copy link
Member

@dirkgr dirkgr commented Apr 23, 2021

While there is no right answer to treating token type ids when folding sequences, this change will at least not lose the information completely.

@dirkgr dirkgr self-assigned this Apr 23, 2021
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

@dirkgr dirkgr merged commit 9091580 into main Apr 26, 2021
@dirkgr dirkgr deleted the TokenTypeIds branch April 26, 2021 23:02
dirkgr added a commit that referenced this pull request May 10, 2021
* Fixes token type ids for folded sequences

* Changelog

* Save memory on the GitHub test runners

* Tensors have to be on the same device
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants