This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Rename sanity_checks to confidence_checks #5201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
reviewed
May 14, 2021
allennlp/training/trainer.py
Outdated
| @@ -294,7 +302,8 @@ def __init__( | |||
| num_gradient_accumulation_steps: int = 1, | |||
| use_amp: bool = False, | |||
| enable_default_callbacks: bool = True, | |||
| run_sanity_checks: bool = True, | |||
| run_sanity_checks: Optional[bool] = None, | |||
There was a problem hiding this comment.
Maybe it's better to just check for this in **kwargs? Either way works, I just thought we had gone with the "kwargs" approach elsewhere. But I don't feel strongly either way.
There was a problem hiding this comment.
Makes sense. I like the **kwargs approach. Updated, along with other suggestions.
ArjunSubramonian
approved these changes
May 14, 2021
Abhishek-P
pushed a commit
to Abhishek-P/allennlp
that referenced
this pull request
Aug 11, 2021
* renaming sanity_checks to confidence_checks * update changelog * docs fix * clean up
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: allenai/allennlp-models#262