Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

save meta data with model archives #5209

Merged
merged 3 commits into from
May 19, 2021
Merged

save meta data with model archives #5209

merged 3 commits into from
May 19, 2021

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented May 17, 2021

Changes proposed in this pull request:

  • Saves meta data in the serialization directory and archive file when training. The meta data is in JSON format, and for now just includes the version used for training, but in the future could include other things such as system info or git info (save git status when run commands #4862).
  • When an archive is loaded, a UserWarning will be issued if the current version of AllenNLP is older than the version that the model was trained on, or if the major versions differ (e.g. 1.2.0 vs 2.2.0) since there is no guarantee of compatibility between major releases.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.
  • codecov/patch reports high test coverage (at least 90%).
    You can find this under the "Actions" tab of the pull request once the other checks have finished.

@epwalsh epwalsh requested a review from AkshitaB May 17, 2021 23:51
@AkshitaB AkshitaB merged commit d2840cb into main May 19, 2021
@AkshitaB AkshitaB deleted the archive-meta branch May 19, 2021 20:34
Abhishek-P pushed a commit to Abhishek-P/allennlp that referenced this pull request Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants