Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Added for saving git info #5701

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

Shreyz-max
Copy link

@Shreyz-max Shreyz-max commented Aug 13, 2022

Change proposed in this pull request:
Saving git repo infos in meta class along with metadata of model archives after going through #4862 issue

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.
  • codecov/patch reports high test coverage (at least 90%).
    You can find this under the "Actions" tab of the pull request once the other checks have finished.

@dirkgr
Copy link
Member

dirkgr commented Aug 17, 2022

Looks good. Can you also add a changelog entry?

@dirkgr dirkgr self-assigned this Aug 17, 2022
@Shreyz-max
Copy link
Author

Looks good. Can you also add a changeling entry?

Do you mean adding it into the changelog?

@dirkgr
Copy link
Member

dirkgr commented Aug 18, 2022

Yes, sorry for the typo. Autocorrect, am I right? 😅

@Shreyz-max
Copy link
Author

Haha, happens to the best of us.

@dirkgr dirkgr enabled auto-merge (squash) August 19, 2022 18:53
auto-merge was automatically disabled August 20, 2022 10:00

Head branch was pushed to by a user without write access

@Shreyz-max
Copy link
Author

Hey @dirkgr this is my first time working on open source and I think by mistake I disabled auto-merge. Also, I have no clue why the tests are not passing. Could you give me some ideas on where and how to start? It will be really helpful.

@dirkgr
Copy link
Member

dirkgr commented Aug 24, 2022

I think auto-merge automatically disables itself when you make a change. Otherwise anyone could push to the branch and it would get merged. It's a safety feature in GitHub.

Let's see if those tests are even still failing.

@dirkgr
Copy link
Member

dirkgr commented Aug 24, 2022

I'm afraid this is a real test failure. The tests now seem to require your git repo to be in a very defined state. We can't have that. It breaks our own tests, and it'll certainly break the tests that @h-vetinari runs in conda-forge.

@Shreyz-max
Copy link
Author

So what should be done next?

@dirkgr
Copy link
Member

dirkgr commented Sep 7, 2022

Look at the error and decide on a path to fix it. It looks to me like it's trying to determine the name of the current branch. What should happen if there isn't a current branch? What should happen if the code is run outside of a git repository?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants