Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling mistake in script.py #2

Closed
wants to merge 1 commit into from
Closed

Fix spelling mistake in script.py #2

wants to merge 1 commit into from

Conversation

allenporter
Copy link
Owner

Proposed change

Fix spelling mistake in script.py, follow up from post merge PR feedback for home-assistant#95188

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

allenporter pushed a commit that referenced this pull request Jan 2, 2024
@chemelli74
Add alarm platform to Comelit (home-assistant#104718)
2cd6c2b 
* initial work on alarm

* final work on alarm

* coveragerc

* add tests

* add code validation

* remove sensor changes for a dedicated PR

* code optimization and cleanup

* tweaks

* tweak #2

* apply suggestion

* code quality

* code quality #2

* fix cover.py

* api typing

* use base classes where possibile

* apply const as per review comment

* cleanup unload entry

* apply review comments
allenporter pushed a commit that referenced this pull request Mar 23, 2024
@dontinelli @joostlek
@autinerd @edenhaus
Add Fyta integration (home-assistant#110816)
98132d1 
* Initial commit for fyta integration

* Update __init__.py

Delete BinarySensor for first PR

* Update __init__.py

Rewind wrongful deletion of comma

* Delete homeassistant/components/fyta/binary_sensor.py

Delete binary_sensor for first pr of integration

* Update manifest.json

Updated requirement to new version of fyta_cli 0.2.1, where bug in import of modules has been resolved.

* Update requirements_test_all.txt

adjust to updated manifest

* Update requirements_all.txt

adjust to updated manifest

* Update test_config_flow.py

* Update config_flow.py

update file to correct error with _entry attribute

* Fyta integration - update initial PR based on review in initial PR home-assistant#110816 (#2)

* adjustments to pass test for config_flow

* backport of changes in intitial PR to dev

* update text_config_flow

* changes based on review in initial PR home-assistant#110816

* Update homeassistant/components/fyta/sensor.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/config_flow.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/config_flow.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/sensor.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/sensor.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/coordinator.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/config_flow.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/strings.json

Co-authored-by: Sid <[email protected]>

* Update homeassistant/components/fyta/strings.json

Co-authored-by: Sid <[email protected]>

* Update homeassistant/components/fyta/manifest.json

Co-authored-by: Sid <[email protected]>

* Adjustments based on PR-commet of Feb 19 (#3)

* add test for config_flow.validate_input

* update based on pr review

* update based on pr review

* further refinings based on PR review

* Update tests/components/fyta/test_config_flow.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update test_config_flow.py

Update tests based on PR comment

* Update homeassistant/components/fyta/sensor.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/sensor.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* add handling and test for duplicate entry

* Update homeassistant/components/fyta/coordinator.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/sensor.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/entity.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update test_config_flow.py

parametrize test for exceptions

* Update config_flow.py

Move _async_abort_entries_match, add arguments

* Update coordinator.py

* Update typing in coordinator.py

* Update coordinator.py

update typing

* Update coordinator.py

corrected typo

* Update coordinator.py

* Update entity.py

* Update sensor.py

* Update icons.json

* Update homeassistant/components/fyta/entity.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/entity.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update entity.py

* Update test_config_flow.py

* Update config_flow.py (change FlowResult to ConfigFlowResult)

* Update config_flow.py

* Update homeassistant/components/fyta/config_flow.py

Co-authored-by: Robert Resch <[email protected]>

* Update homeassistant/components/fyta/config_flow.py

Co-authored-by: Robert Resch <[email protected]>

* Update homeassistant/components/fyta/coordinator.py

Co-authored-by: Robert Resch <[email protected]>

* Update coordinator.py

* Update config_flow.py (typing FlowResult -> ConfigFlowResult)

* Update config_flow.py

* Aktualisieren von config_flow.py

* remove coordinator entities

* Update strings.json

remove plant_number

* Update icons.json

remove plant_number

* Update manifest.json

Update requirement to latest fyta_cli version

* Update requirements_all.txt

* Update requirements_test_all.txt

* Update homeassistant/components/fyta/sensor.py

* Update homeassistant/components/fyta/sensor.py

* Update homeassistant/components/fyta/coordinator.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/coordinator.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/coordinator.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/entity.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/strings.json

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update homeassistant/components/fyta/strings.json

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update tests/components/fyta/test_config_flow.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Update tests/components/fyta/test_config_flow.py

Co-authored-by: Joost Lekkerkerker <[email protected]>

* move test-helpers into conftest.py, adjust import of coordinator.py

---------

Co-authored-by: Joost Lekkerkerker <[email protected]>
Co-authored-by: Sid <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@allenporter