Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error with C++23 #127

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix compilation error with C++23 #127

merged 1 commit into from
Feb 12, 2024

Conversation

Nukoooo
Copy link
Contributor

@Nukoooo Nukoooo commented Feb 12, 2024

Before fix it gives this error:

amtl/am-string.h:184:16: error: conversion function from 'std::nullptr_t' to 'std::string' (aka 'basic_string<char>') invokes a deleted function
  184 |         return nullptr;

Returning an empty string fixes the problem and works as intended according to this:

There are several possible ways to fix this code; you could pass an empty string with "" or std::string{} or even {} (depending on whether open_choices() is overloaded).

from mamedev/mame#8265

@dvander dvander merged commit 6969677 into alliedmodders:master Feb 12, 2024
1 check passed
@dvander
Copy link
Member

dvander commented Feb 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants