Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a filter to translate the image to the detected head or eyes #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schuellerf
Copy link

I just wanted to play around with a mainly transparent image just containing some text which floats next to my head.
It seems to work and does what I intended to

@allo- allo- added the enhancement New feature or request label Jun 30, 2021
@allo-
Copy link
Owner

allo- commented Jun 30, 2021

Can you change the class Name (not the filter name) to CamelCase to match the other filters?

I tested it by moving the background image.
Maybe you like to have a look as well either for this filter or maybe as another one. I think by reversing the tracking direction (or not fixing a point?) one could create an interesting parallax effect that looks like the camera is moving around when the background image is moved.
But that's just an idea, maybe I look into playing with this when you're not interested yourself.

@allo-
Copy link
Owner

allo- commented Jun 30, 2021

And maybe you should rebase it onto my branch to check for any conflicts. But I think there were no breaking changes (except that it will break when using mediapipe, but the other filters using part masks are currently broken with mediapipe as well).

@schuellerf
Copy link
Author

Which branch? Due to
mrxz#1
I'm actually based on this "gui" branch but I wanted to keep this separated for your convenience

@schuellerf
Copy link
Author

Can you change the class Name (not the filter name) to CamelCase to match the other filters?

I tested it by moving the background image.
Maybe you like to have a look as well either for this filter or maybe as another one. I think by reversing the tracking direction (or not fixing a point?) one could create an interesting parallax effect that looks like the camera is moving around when the background image is moved.
But that's just an idea, maybe I look into playing with this when you're not interested yourself.

For a parallax effect, I would also include to enrich the image scaling to be able to scale larger than the webcam dimensions (for now there is only scaling with the resulting image being the webcam resolution again, I think)

@allo-
Copy link
Owner

allo- commented Jul 1, 2021

Which branch?

Rebase and change the class name on the branch you want to merge (currently schuellerf:master).

For a parallax effect, I would also include to enrich the image scaling to be able to scale larger than the webcam dimensions (for now there is only scaling with the resulting image being the webcam resolution again, I think)

Indeed, the Image moved around over a black background, but having an image larger than the output frame is not that complicated. I am not sure how to fit it in the current pipeline which passes webcam size frames around, but for the effect alone maybe the filter could load the image itself and then re-use the head tracking filter.

I'd need to read what other movements belong to a real parallax effect. It just looked already similar when I tested moving around the background image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants