Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest-assured): add support for headers blacklist #1007

Conversation

antonfilichkin
Copy link
Contributor

@antonfilichkin antonfilichkin commented Feb 11, 2024

Context

RestAssured from version 4.2.0 added possibility to blacklist headers in the request or response logs.
This adds a configurable option to consider blacklisted headers from the RestAssured LogConfiguration and blacklist them in the Allure report as well. Enabled by default, so if there is a need to expose header blacklisted by RestAssured in Allure report it must be set explicitly.
This makes Allure report to blacklist the same headers.

Example of header blacklisted in Allure report:
image

Checklist

antonfilichkin and others added 2 commits March 1, 2024 18:10
# Conflicts:
#	allure-rest-assured/src/test/java/io/qameta/allure/restassured/AllureRestAssuredTest.java
@baev baev added the type:improvement Change that improves some user experience but can't be considered as a new feature label Mar 18, 2024
@baev
Copy link
Member

baev commented Mar 19, 2024

Meanwhile, I don't like the used wording (blacklist and blacklisted). Now, most software uses allowlist and denylist instead. However, this is the exact copy of the behaviour from RestAssured, and I don't see any point to introduce additional UX complications for RestAssured users.

@antonfilichkin antonfilichkin force-pushed the consider_rest_assured_blacklisted_headers branch from 6c48813 to bd452a3 Compare March 19, 2024 19:07
@baev baev changed the title Add configurable option for Allure filter to follow RestAssured headers blacklist feat(rest-assured): add support for headers blacklist Mar 22, 2024
@baev baev merged commit 6ff650c into allure-framework:main Mar 22, 2024
4 checks passed
@baev
Copy link
Member

baev commented Mar 22, 2024

@antonfilichkin thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:rest-assured type:improvement Change that improves some user experience but can't be considered as a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants