-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest-assured): add support for headers blacklist #1007
Merged
baev
merged 10 commits into
allure-framework:main
from
antonfilichkin:consider_rest_assured_blacklisted_headers
Mar 22, 2024
Merged
feat(rest-assured): add support for headers blacklist #1007
baev
merged 10 commits into
allure-framework:main
from
antonfilichkin:consider_rest_assured_blacklisted_headers
Mar 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # allure-rest-assured/src/test/java/io/qameta/allure/restassured/AllureRestAssuredTest.java
baev
reviewed
Mar 18, 2024
allure-rest-assured/src/main/java/io/qameta/allure/restassured/AllureRestAssured.java
Outdated
Show resolved
Hide resolved
baev
added
the
type:improvement
Change that improves some user experience but can't be considered as a new feature
label
Mar 18, 2024
Meanwhile, I don't like the used wording ( |
antonfilichkin
force-pushed
the
consider_rest_assured_blacklisted_headers
branch
from
March 19, 2024 19:07
6c48813
to
bd452a3
Compare
baev
approved these changes
Mar 21, 2024
baev
changed the title
Add configurable option for Allure filter to follow RestAssured headers blacklist
feat(rest-assured): add support for headers blacklist
Mar 22, 2024
@antonfilichkin thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
theme:rest-assured
type:improvement
Change that improves some user experience but can't be considered as a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
RestAssured from version 4.2.0 added possibility to blacklist headers in the request or response logs.
This adds a configurable option to consider blacklisted headers from the RestAssured LogConfiguration and blacklist them in the Allure report as well. Enabled by default, so if there is a need to expose header blacklisted by RestAssured in Allure report it must be set explicitly.This makes Allure report to blacklist the same headers.
Example of header blacklisted in Allure report:
Checklist