This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Timeline .focus() should also zoom in as well as zoom out. Fix vertical scroll when not using groups or rtl = true #4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l scroll when not using groups or rtl = true. Fixes almende#3389, almende#2475
nathanboktae
commented
Jul 17, 2018
| setTimeout(setFinalVerticalPosition, 100); | ||
| }; | ||
|
|
||
| // calculate the new middle and interval for the window | ||
| var middle = (start + end) / 2; | ||
| var interval = Math.max(this.range.end - this.range.start, (end - start) * 1.1); | ||
| var interval = (end - start) * 1.1; |
There was a problem hiding this comment.
Math.max ensured a zoom out, but never a zoom in, which is odd. make the behavior more consistent by just snapping to the item with 5% buffer on each side.
|
Can you resubmit this PR implemented in the new fork I've moved to here: |
|
I've now branched out to a new fork of my own including only Timeline. |
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3389, #2475