This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Proposed fix for bug 4079. Seed LayoutEngine random only at the beginning. #4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t construction or configuration time, not every time nodes are added.
|
@yotamberk could you tag this one as |
|
@soinio thanks for the sending this PR with the fix! Curious, could you provide a new example that we can use to verify the fix, or point us to an existing example that shows the bug behavior? https://github.com/almende/vis/tree/master/examples/network said another way, could you provide steps to test this PR? |
17 tasks
29 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for bug #4079. Makes LayoutEngine seed it's random only at construction or configuration time, not every time nodes are added.