Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Allow setting title of customtime in constructor #4117

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kbasten
Copy link

@kbasten kbasten commented Sep 9, 2018

This allows setting of custom time bar title in the constructor, allowing calls like the following to correctly display the title.

graph.addCustomTime(new Date(1531135747 * 1000), 'custom_id', { title: 'custom title' });

@yotamberk
Copy link
Contributor

I've now branched out to a new fork of my own including only Timeline.
I've applied your change here: https://github.com/yotamberk/timeline-plus
and can be used via npm here: https://www.npmjs.com/package/timeline-plus
Awesome fix! Thanks for your contribution! Future PRs will be reviewed and added in the new fork

Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants