This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
handle preventDefault per-keybind #3906 #4176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, Vivaldi supports one-key shortcuts, so I'm not sure this is a proper suggestion. Does this default prevention cause any actual problems? |
29 tasks
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, all keybinds are having their defaults prevented. This PR only calls preventDefault on keys that are not combined with ctrl, shift, or alt, because those are modifiers for normal browser hotkeys.
The same should probably be done for scroll events, considering that ctrl+scrollwheel will simultaneously zoom in/out on the canvas as well as the window. Perhaps there should be an interaction option that allows which keybinds should propogate?
Looking forward to feedback.