Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Fix useDefaultGroups option in Groups module #4280

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mashlol
Copy link

@mashlol mashlol commented Apr 5, 2019

The docs (http://visjs.org/docs/network/groups.html#) indicate that if useDefaultGroups is passed as false, it will iterate through the provided groups to use as defaults instead. But the code doesn't seem to match that description, as useDefaultGroups is ignored, and the code that handles it being false doesn't seem quite right (it should fetch the full group, not just the color)

The docs (http://visjs.org/docs/network/groups.html#) indicate that if `useDefaultGroups` is passed as false, it will iterate through the provided groups to use as defaults instead. But the code doesn't seem to match that description, as `useDefaultGroups` is ignored, and the code that handles it being false doesn't seem quite right (it should fetch the full group, not just the color)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants