Skip to content

Commit

Permalink
Test with Github Actions for magefile
Browse files Browse the repository at this point in the history
  • Loading branch information
alperencelik committed Jan 6, 2024
1 parent 6549749 commit d4e52fc
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions magefile.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ package main
import (
"fmt"
"log"
"os"
"path/filepath"

"github.com/carolynvs/magex/pkg"
Expand Down Expand Up @@ -103,7 +102,7 @@ func releaseWithGoReleaser(snapshot bool) error {
return fmt.Errorf("KO couldn't be installed: %w", err)
}

err := sh.RunV("ko", "login", "dockerhub", "-u", os.Getenv("DOCKERHUB_USERNAME"), "-p", os.Getenv("DOCKERHUB_PASSWORD"))
err := sh.RunV("ko", "login", "dockerhub", "-u", "${{ secrets.DOCKERHUB_USERNAME }}", "-p", "${{ secrets.DOCKERHUB_PASSWORD }}")
if err != nil {
return fmt.Errorf("ko login failed")
}
Expand Down

0 comments on commit d4e52fc

Please sign in to comment.